refactor: update text input logic to v2 TextFieldState, part 1 [WPB-8779] #3010

saleniuk · 2024-05-15T15:21:55Z

WPB-8779 Introduce BasicTextField2

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Android Compose has new v2 version of text field inputs, and with that, they are going away from the previous approach with TextFieldValue and onValueChanged and replacing it with TextFieldState.
We already updated text fields to v2 but still are using "hybrid" solution which synchronises between TextFieldValue/onValueChanged and TextFieldState.

In this PR, following screens, their ViewModels logic and tests are updated to use TextFieldState:

CreateAccountUsernameScreen
ChangeDisplayNameScreen
ChangeEmailScreen
ChangeHandleScreen

Also, ShakeAnimation is fixed/updated, translationX in graphicsLayer is used instead of offset to make it lighter and smoother.

Testing

Test Coverage (Optional)

I have added automated test to this contribution

How to Test

Use text fields from any of listed screens.

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…779]

github-actions · 2024-05-15T15:25:42Z

Test Results

930 tests - 2 930 ✅ - 2 9m 17s ⏱️ - 1m 54s
124 suites ±0 0 💤 ±0
124 files ±0 0 ❌ ±0

Results for commit e43d818. ± Comparison against base commit 2b4b52e.

This pull request removes 2 tests.

com.wire.android.ui.authentication.create.username.CreateAccountUsernameViewModelTest ‑ given forbidden character, when entering username, then forbidden character is ignored()
com.wire.android.ui.home.settings.account.displayname.ChangeDisplayNameViewModelTest ‑ when calling onAnimatedError, should emit animatedNameError false to clean state()

♻️ This comment has been updated with latest results.

github-actions · 2024-05-15T16:02:53Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2024-05-15T16:42:33Z

Build 4764 succeeded.

The build produced the following APK's:

com.wire.android-v4.8.0(9682055)(9682055)-staging-compat.apk

codecov-commenter · 2024-05-15T16:42:52Z

Codecov Report

Attention: Patch coverage is 86.48649% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 44.29%. Comparing base (2b4b52e) to head (e43d818).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3010      +/-   ##
===========================================
+ Coverage    44.20%   44.29%   +0.09%     
===========================================
  Files          447      448       +1     
  Lines        14558    14508      -50     
  Branches      2497     2490       -7     
===========================================
- Hits          6435     6426       -9     
+ Misses        7428     7380      -48     
- Partials       695      702       +7

Files	Coverage Δ
.../create/username/CreateAccountUsernameViewState.kt	`100.00% <ø> (ø)`
...e/settings/account/displayname/DisplayNameState.kt	`100.00% <100.00%> (ø)`
.../home/settings/account/handle/ChangeHandleState.kt	`100.00% <ø> (ø)`
.../src/main/kotlin/com/wire/android/util/Patterns.kt	`100.00% <100.00%> (ø)`
...ings/account/email/updateEmail/ChangeEmailState.kt	`90.00% <85.71%> (-10.00%)`	⬇️
...e/settings/account/handle/ChangeHandleViewModel.kt	`89.28% <91.66%> (+4.43%)`	⬆️
.../account/displayname/ChangeDisplayNameViewModel.kt	`92.00% <88.23%> (-1.03%)`	⬇️
.../account/email/updateEmail/ChangeEmailViewModel.kt	`86.11% <84.61%> (+23.36%)`	⬆️
.../create/username/CreateAccountUsernameViewModel.kt	`86.20% <80.00%> (+4.81%)`	⬆️

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b4b52e...e43d818. Read the comment docs.

alexandreferris

Amazing work!

got just 2 comments for the returned error type and checking

.../kotlin/com/wire/android/ui/authentication/create/username/CreateAccountUsernameViewModel.kt

...n/kotlin/com/wire/android/ui/home/settings/account/displayname/ChangeDisplayNameViewModel.kt

…-v2-textfieldstate-pt1

github-actions · 2024-05-21T08:11:30Z

APKs built during tests are available here. Scroll down to Artifacts!

github-actions · 2024-05-21T08:46:11Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2024-05-21T09:08:47Z

Build 4827 succeeded.

The build produced the following APK's:

com.wire.android-v4.8.0(9731262)(9731262)-staging-compat.apk

ohassine

LGTM 👌
Just one thing: we are using an alpha version of compose-foundation and compose-material-android, I'd suggest to upgrade it to latest version 1.7.0-beta01

…ndroid to newest beta

…-v2-textfieldstate-pt1 # Conflicts: # app/src/main/kotlin/com/wire/android/ui/common/textfield/WirePasswordTextField.kt

pull-request-size · 2024-05-22T11:05:04Z

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

sonarcloud · 2024-05-22T11:11:33Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.2% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-05-22T11:44:10Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2024-05-22T12:27:54Z

Build 4888 succeeded.

The build produced the following APK's:

com.wire.android-v4.8.0(9740969)(9740969)-staging-compat.apk

saleniuk added 2 commits May 15, 2024 16:43

refactor: update text input logic to v2 TextFieldState, part 1 [WPB-8…

e4efd4b

…779]

clean-up

1e3d282

pull-request-size bot added the size/L label May 15, 2024

github-actions bot assigned saleniuk May 15, 2024

detekt

3564f59

saleniuk requested review from a team, typfel, alexandreferris, mchenani, Garzas and ohassine and removed request for a team May 16, 2024 06:52

alexandreferris reviewed May 16, 2024

View reviewed changes

.../kotlin/com/wire/android/ui/authentication/create/username/CreateAccountUsernameViewModel.kt Show resolved Hide resolved

...n/kotlin/com/wire/android/ui/home/settings/account/displayname/ChangeDisplayNameViewModel.kt Show resolved Hide resolved

yamilmedina mentioned this pull request May 16, 2024

feat: Github actions upload to S3 #3009

Closed

8 tasks

saleniuk requested a review from alexandreferris May 17, 2024 13:03

Merge remote-tracking branch 'origin/develop' into refactor/update-to…

23a28cf

…-v2-textfieldstate-pt1

Garzas approved these changes May 21, 2024

View reviewed changes

add explanation to the SnapshotExtension

bd15d49

add explanation to the SnapshotExtension

94b1d37

ohassine approved these changes May 21, 2024

View reviewed changes

saleniuk added 3 commits May 22, 2024 12:57

changes required to upgrade compose-foundation and compose-material-a…

6804e00

…ndroid to newest beta

remove unused import

83b44bf

Merge remote-tracking branch 'origin/develop' into refactor/update-to…

1ea855d

…-v2-textfieldstate-pt1 # Conflicts: # app/src/main/kotlin/com/wire/android/ui/common/textfield/WirePasswordTextField.kt

fix after merge

2616c8c

pull-request-size bot added size/XL and removed size/L labels May 22, 2024

fix: detekt issues

e43d818

saleniuk added this pull request to the merge queue May 22, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 22, 2024

saleniuk added this pull request to the merge queue May 22, 2024

Merged via the queue into develop with commit 1aec80d May 22, 2024
13 checks passed

saleniuk deleted the refactor/update-to-v2-textfieldstate-pt1 branch May 22, 2024 13:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: update text input logic to v2 TextFieldState, part 1 [WPB-8779] #3010

refactor: update text input logic to v2 TextFieldState, part 1 [WPB-8779] #3010

saleniuk commented May 15, 2024 •

edited by github-actions bot

Loading

github-actions bot commented May 15, 2024 •

edited

Loading

github-actions bot commented May 15, 2024

AndroidBob commented May 15, 2024

codecov-commenter commented May 15, 2024 •

edited

Loading

alexandreferris left a comment

github-actions bot commented May 21, 2024

github-actions bot commented May 21, 2024

AndroidBob commented May 21, 2024

ohassine left a comment

pull-request-size bot commented May 22, 2024

sonarcloud bot commented May 22, 2024

github-actions bot commented May 22, 2024

AndroidBob commented May 22, 2024

refactor: update text input logic to v2 TextFieldState, part 1 [WPB-8779] #3010

refactor: update text input logic to v2 TextFieldState, part 1 [WPB-8779] #3010

Conversation

saleniuk commented May 15, 2024 • edited by github-actions bot Loading

PR Submission Checklist for internal contributors

What's new in this PR?

Testing

Test Coverage (Optional)

How to Test

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

github-actions bot commented May 15, 2024 • edited Loading

Test Results

github-actions bot commented May 15, 2024

AndroidBob commented May 15, 2024

codecov-commenter commented May 15, 2024 • edited Loading

Codecov Report

alexandreferris left a comment

Choose a reason for hiding this comment

github-actions bot commented May 21, 2024

github-actions bot commented May 21, 2024

AndroidBob commented May 21, 2024

ohassine left a comment

Choose a reason for hiding this comment

pull-request-size bot commented May 22, 2024

Ups 🫰🟨

sonarcloud bot commented May 22, 2024

Quality Gate passed

github-actions bot commented May 22, 2024

AndroidBob commented May 22, 2024

saleniuk commented May 15, 2024 •

edited by github-actions bot

Loading

github-actions bot commented May 15, 2024 •

edited

Loading

codecov-commenter commented May 15, 2024 •

edited

Loading